grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC 0/3] Add/use helper functions for finding UEFI config tables


From: Alexander Graf
Subject: Re: [RFC 0/3] Add/use helper functions for finding UEFI config tables
Date: Tue, 1 Mar 2016 19:38:15 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 03/01/2016 06:41 PM, Leif Lindholm wrote:
(Triggered by Alex's recent patches)

There are a few places in the code manually iterating across the
config tables provided through the UEFI system table. This set
implements a common search function and converts some existing
functions to use it.

I have not yet converted commands/efi/loadbios.c given that it
searches for multiple things in one go. Would be a trivial change.

Also, for cleanliness of call-sites a better approach may be to macroize
the function so that it was possible to simply go:
   ptr = grub_efi_find_config_table(MY_VERY_SPECIAL_GUID);
This was not my preference, since that hides the fact that the
underlying datatype is a 128-bit struct.

Looks reasonable to me.

Reviewed-by: Alexander Graf <address@hidden>


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]