Re: [PATCH] bootp: set is_def while processing dhcp ack

[Nikunj A Dadhania]

Andrei Borzenkov <address@hidden> writes:

> 17.03.2016 11:45, Nikunj A Dadhania пишет:
>> Andrei Borzenkov <address@hidden> writes:
>> 
>>> On Thu, Mar 17, 2016 at 11:04 AM, Nikunj A Dadhania
>>> <address@hidden> wrote:
>>>> net_default_interface=ofnet_net:dhcp
>>>> net_default_ip=(null)
>>>> net_default_mac=(null)
>>>> net_default_server=10.0.2.2
>>>> net_ofnet_net_dhcp_boot_file=ubuntu-installer/ppc64el/powerpc-ieee1275/core.elf
>>>> net_ofnet_net_dhcp_ip=10.0.2.15
>>>> net_ofnet_net_dhcp_mac=52:54:00:12:34:56
>>>
>>>
>>> OK, we probably need to export not only name, but also IP to match
>>> default case. Could you attach bootp reply packet?
>> 
>> Attached the pcap file, it has the request as well as the ack.
>> 
>>> I wonder if anyone ever seen or used net_if_dhcp_server_name variable;
>>> because net_boot sets interface name to card:dhcp, this actually
>>> becomes net_card_dhcp_dhcp_server_name. Someone would sure have
>>> noticed it.
>> 
>
> Please test attached patch. It sets net_<card>_dhcp_server_ip variable.
>
> We probably need to offer programmatic way to iterate through all cards
> in CLI. But as long as you have single card with known name it should be
> OK.

So the variable net_ofnet_net_dhcp_server_ip is set now, although the
boot does not proceed and bails out.


    
net_ofnet_net_dhcp_boot_file=ubuntu-installer/ppc64el/powerpc-ieee1275/core.elf
    net_ofnet_net_dhcp_ip=10.0.2.15
    net_ofnet_net_dhcp_mac=52:54:00:12:34:56
    net_ofnet_net_dhcp_server_ip=10.0.2.2
    pager=1
    prefix=(ieee1275/disk,msdos2)/grub
    pxe_default_server=
    root=ieee1275/disk,msdos2
    secondary_locale_dir=
    Loading Linux ...
    error: no server is specified.

Regards
Nikunj