Re: [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64

[Julien Grall]

Hello,

Ping?

Regards,

On 19/02/16 16:28, Julien Grall wrote:
> Xen is currently crashing because of malformed compatible property for
> the boot module. This is because the property string is not
> null-terminated as requested by the ePAR spec.
> ---
>   grub-core/loader/arm64/xen_boot.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/loader/arm64/xen_boot.c 
> b/grub-core/loader/arm64/xen_boot.c
> index a914eb8..8ae43d7 100644
> --- a/grub-core/loader/arm64/xen_boot.c
> +++ b/grub-core/loader/arm64/xen_boot.c
> @@ -156,7 +156,7 @@ prepare_xen_module_params (struct xen_boot_binary *module, 
> void *xen_boot_fdt)
>         grub_fdt_add_subnode (xen_boot_fdt, chosen_node, module_name);
>
>     retval = grub_fdt_set_prop (xen_boot_fdt, module_node, "compatible",
> -                             MODULE_CUSTOM_COMPATIBLE, 
> sizeof(MODULE_CUSTOM_COMPATIBLE) - 1);
> +                             MODULE_CUSTOM_COMPATIBLE, 
> sizeof(MODULE_CUSTOM_COMPATIBLE));
>     if (retval)
>       return grub_error (GRUB_ERR_IO, "failed to update FDT");

--
Julien Grall