Re: [PATCH 4/8] xen: add xen pvh guest support to grub-core

[Daniel Kiper]

On Wed, Nov 29, 2017 at 02:46:46PM +0100, Juergen Gross wrote:
> Add all the grub-core code needed for Xen PVH guest support. This
> includes:
>
> - The new PVH entry point of grub
> - PVH specific initialization code
> - machine specific header files
> - modifications in Xen specific code to work in PVH environment
> - modifications in other core code to be reusable with PVH
>
> Enabling all this code is done later.
>
> Signed-off-by: Juergen Gross <address@hidden>
> ---
>  grub-core/kern/i386/tsc.c             |   2 +-
>  grub-core/kern/i386/xen/pvh.c         | 344 
> ++++++++++++++++++++++++++++++++++
>  grub-core/kern/i386/xen/startup_pvh.S |  80 ++++++++
>  grub-core/kern/xen/init.c             |  66 ++++---
>  include/grub/i386/pc/int.h            |   3 +
>  include/grub/i386/tsc.h               |   2 +-
>  include/grub/i386/xen/hypercall.h     |   5 +-
>  include/grub/i386/xenpvh/boot.h       |   1 +
>  include/grub/i386/xenpvh/console.h    |   1 +
>  include/grub/i386/xenpvh/int.h        |   1 +
>  include/grub/i386/xenpvh/kernel.h     |  30 +++
>  include/grub/i386/xenpvh/memory.h     |  54 ++++++
>  include/grub/i386/xenpvh/time.h       |   1 +
>  include/grub/kernel.h                 |   4 +-
>  include/grub/offsets.h                |   3 +
>  include/grub/xen.h                    |   6 +
>  16 files changed, 573 insertions(+), 30 deletions(-)
>  create mode 100644 grub-core/kern/i386/xen/pvh.c
>  create mode 100644 grub-core/kern/i386/xen/startup_pvh.S
>  create mode 100644 include/grub/i386/xenpvh/boot.h
>  create mode 100644 include/grub/i386/xenpvh/console.h
>  create mode 100644 include/grub/i386/xenpvh/int.h
>  create mode 100644 include/grub/i386/xenpvh/kernel.h
>  create mode 100644 include/grub/i386/xenpvh/memory.h
>  create mode 100644 include/grub/i386/xenpvh/time.h

May I ask you to split this patch into smaller logical entities?

Daniel