Re: [PATCH v2] grub-install: locale depends on nls

[Daniel Kiper]

On Wed, Mar 07, 2018 at 10:54:28PM +0100, Olaf Hering wrote:
> Am Wed, 7 Mar 2018 22:30:53 +0100
> schrieb Daniel Kiper <address@hidden>:
>
> > Sorry, I do not like it. Please use "__attribute__ ((unused))" for the 
> > function
> > arguments and put #if/#endif around its whole body.
>
> It is not just this function body, many more parts will be unneeded.

I am not sure what are you talking about.

> Really polluted the entire file with #if and __attributes__?

I think that you have two choices here. You can add __attribute__ to
grub_install_copy_nls() or #if#endif whole function and its call.
Both are not perfect. However, if you would ask me I probably would
choose the latter.

Daniel