Re: [PATCHv2] os-prober: Fix translating device to mach format

[Samuel Thibault]

Daniel Kiper, on jeu. 22 mars 2018 15:16:46 +0100, wrote:
> On Wed, Mar 14, 2018 at 02:14:08PM +0100, Samuel Thibault wrote:
> > @@ -297,8 +297,8 @@ menuentry '$(echo "${LONGNAME} $onstr" | grub_quote)' 
> > --class hurd --class gnu -
> >  EOF
> >        save_default_entry | grub_add_tab
> >        prepare_grub_to_access_device ${DEVICE} | grub_add_tab
> > -      grub_device="`${grub_probe} --device ${DEVICE} --target=drive`"
> > -      mach_device="`echo "${grub_device}" | sed -e 
> > 's/(\(hd.*\),msdos\(.*\))/\1s\2/'`"
> > +      grub_device="`${grub_probe} --device ${DEVICE} 
> > --target=compatibility_hint`"
> > +      mach_device="`echo "${grub_device}" | sed -e 
> > 's/\(hd.*\),msdos\(.*\)/\1s\2/'`"
> 
> Why do you drop parentheses here?

Well, because there are none in the compatibility_hint output :)

Samuel