Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

[Hans de Goede]

Hi,

On 28-03-18 17:11, Lennart Sorensen wrote:
> On Wed, Mar 28, 2018 at 05:06:53PM +0200, Hans de Goede wrote:
> > Hmm, well people will still be able to use ESC to get the grub boot
> > menu, rather then the firmware boot-menu on those.
> >
> > The problem is that our current check for ESC only approach is problematic
> > because it conflicts with the enter firmware-setup key on almost all Bay Trail,
> > Cherry Trail and Apollo Lake devices. You need to try hard to find a device
> > in one of those 3 categories which does not use ESC for this. Note I'm
> > aware some devices exist, but using ESC for this is really really common
> > among these devices.
> >
> > I'm open to other suggestions, but I think we really need to add another
> > key to avoid the pressing ESC at boot already has another meaning problem
> > and F8 seems like an ok choice.
> >
> > Either way thank you for the input on this.
>
> I don't disagree about having another key, I just disagree that F8 is
> a good choice.
>
> Looking at https://kb.wisc.edu/page.php?id=58779#here it appears no one
> uses F4 for anything.  That would seem like a better choice than F8
> at least.  F6 also seems to be free but F4 seems nicer on desktop
> keyboards.

Looking at that table I have to agree that F4 seems like the best second
key to use. Actually looking at that table ESC seems like a poor choice,
but I guess it makes sense for serial-terminals as well as from a general
UI pov (and we're stuck with it now anyways).

I'm going to wait for Daniel's review of the other patches before I do
a v2 of this patch-set. I will switch to F4 for v2.

Regards,

Hans