[Guile-commits] GNU Guile branch, branch_release-1-8, updated. release_1-8-6-59-g8510e39

[Neil Jerram]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Guile".

http://git.savannah.gnu.org/cgit/guile.git/commit/?id=8510e39278161d3cbf8ec4ba87b123fe28763ed4

The branch, branch_release-1-8 has been updated
       via  8510e39278161d3cbf8ec4ba87b123fe28763ed4 (commit)
      from  0367cb9d56601b627b361191d0a6e7e3892f1de7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8510e39278161d3cbf8ec4ba87b123fe28763ed4
Author: Neil Jerram <address@hidden>
Date:   Thu Jun 25 21:40:32 2009 +0100

    Remove GDB_INTERFACE stuff from guile's main program
    
    The main motivation for this is wanting a successful MinGW build,
    which is currently failing with:
    
    guile-guile.o: In function `inner_main':
    /home/neil/SW/Guile/ovnight/libguile/guile.c:55: undefined reference to 
`__imp__gdb_result'
    /home/neil/SW/Guile/ovnight/libguile/guile.c:55: undefined reference to 
`__imp__gdb_output'
    /home/neil/SW/Guile/ovnight/libguile/guile.c:55: undefined reference to 
`__imp__gdb_output_length'
    
    The detailed problem here is to do with how those variables are
    declared as exported from the libguile DLL and imported by the guile.c
    main program.  But in fact we don't need to solve that problem because
    the GDB interface is an idea that never actually happened.  So here we
    just remove the offending variable references from guile.c.
    
    For the record, Guile contains two kinds of GDB support, one of which
    is real (and works, last time I tried it), and the other mythical.
    
    The first kind is that libguile includes the utility functions
    gdb_print, gdb_eval, etc., and the variable gdb_output.  These have no
    purpose except for developers to use from GDB when debugging
    something.  For example, if you have a SCM x and want to know what it
    is, you can do:
    
    (gdb) call gdb_print(x)
    (gdb) p gdb_output
    
    The second kind is that those utility functions are somehow declared
    to GDB, and then GDB itself uses/calls them in some useful way.  This
    was an interesting idea, but (AFAICT) never actually happened.
    
    I think it's worth leaving gdb_interface.h in the repository and the
    distribution, in case this idea is properly resurrected in the future.
    
    * libguile/guile.c (top level): Remove GDB_INTERFACE declaration.
      (inner_main): Remove GDB_INTERFACE_INIT call.

-----------------------------------------------------------------------

Summary of changes:
 libguile/guile.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/libguile/guile.c b/libguile/guile.c
index c8341c2..3e01b57 100644
--- a/libguile/guile.c
+++ b/libguile/guile.c
@@ -40,11 +40,6 @@
 #include <winsock2.h>
 #endif
 
-/* Debugger interface (don't change the order of the following lines) */
-#define GDB_TYPE SCM
-#include <libguile/gdb_interface.h>
-GDB_INTERFACE;
-
 static void
 inner_main (void *closure SCM_UNUSED, int argc, char **argv)
 {
@@ -52,7 +47,6 @@ inner_main (void *closure SCM_UNUSED, int argc, char **argv)
   /* This is necessary to startup the Winsock API under Win32. */
   WSADATA WSAData;
   WSAStartup (0x0202, &WSAData);
-  GDB_INTERFACE_INIT;
 #endif /* __MINGW32__ */
 
   /* module initializations would go here */


hooks/post-receive
-- 
GNU Guile