[Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.5-3-g52de2ab

[Andy Wingo]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Guile".

http://git.savannah.gnu.org/cgit/guile.git/commit/?id=52de2ab45ab77ca5a2d6443278c7f654cdc60fb2

The branch, stable-2.0 has been updated
       via  52de2ab45ab77ca5a2d6443278c7f654cdc60fb2 (commit)
      from  7e9a301b7f3bcc811803305250b22d71a8b06155 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 52de2ab45ab77ca5a2d6443278c7f654cdc60fb2
Author: Andy Wingo <address@hidden>
Date:   Thu Feb 2 00:10:11 2012 +0100

    leniency in the "unused modules are removed" gc.test
    
    * libguile/foreign.h: Remove comment about the finalizer bit, as I don't
      think that is the case any more.
    
    * test-suite/tests/gc.test: Ignore flakiness in the gc-modules test.

-----------------------------------------------------------------------

Summary of changes:
 libguile/foreign.h       |    5 ++---
 test-suite/tests/gc.test |   21 ++++++++++++++++-----
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/libguile/foreign.h b/libguile/foreign.h
index 6c6f373..75e3bf5 100644
--- a/libguile/foreign.h
+++ b/libguile/foreign.h
@@ -1,7 +1,7 @@
 #ifndef SCM_FOREIGN_H
 #define SCM_FOREIGN_H
 
-/* Copyright (C) 2010, 2011  Free Software Foundation, Inc.
+/* Copyright (C) 2010, 2011, 2012  Free Software Foundation, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public License
@@ -23,8 +23,7 @@
 
 /* A "foreign pointer" is a wrapped C pointer.  It is represented by a
    cell whose second word is a pointer.  The first word has the
-   `scm_tc7_pointer' type code and a bit saying whether it has an
-   associated finalizer or not.
+   `scm_tc7_pointer' type code.
 
    The basic idea is that we can help the programmer to avoid cutting herself,
    but we won't take away her knives.  */
diff --git a/test-suite/tests/gc.test b/test-suite/tests/gc.test
index 1afcea3..e13c8f7 100644
--- a/test-suite/tests/gc.test
+++ b/test-suite/tests/gc.test
@@ -22,6 +22,16 @@
   #:use-module ((system base compile) #:select (compile)))
 
 
+;; Some of these tests verify that things are collectable.  As we use a
+;; third-party conservative collector, we really can't guarantee that --
+;; we can try, but on some platforms, on some versions (possibly), the
+;; test might fail.  But we don't want that to stop the build.  So,
+;; instead of failing, throw 'unresolved.
+;;
+(define (maybe-gc-flakiness result)
+  (or result
+      (throw 'unresolved)))
+
 ;;;
 ;;; miscellaneous
 ;;;
@@ -73,11 +83,12 @@
       (gc)   ;; thrice: because the test doesn't succeed with only
       ;; one gc round. not sure why.
 
-      (= (let lp ((i 0))
-           (if (guard)
-               (lp (1+ i))
-               i))
-         total)))
+      (maybe-gc-flakiness
+       (= (let lp ((i 0))
+            (if (guard)
+                (lp (1+ i))
+                i))
+          total))))
 
   (pass-if "Lexical vars are collectable"
     (let ((l (compile


hooks/post-receive
-- 
GNU Guile