guile/guile-core HACKING libguile/ChangeLog lib...

[Dirk Herrmann]

CVSROOT:        /cvs
Module name:    guile
Changes by:     Dirk Herrmann <address@hidden>  00/12/28 08:06:56

Modified files:
        guile-core     : HACKING 
        guile-core/libguile: ChangeLog continuations.c 

Log message:
        * Get rid of the annoying variable-gets-clobbered-by-longjmp warning.

CVSWeb URLs:
http://subversions.gnu.org/cgi-bin/cvsweb/guile/guile-core/HACKING.diff?r1=1.40&r2=1.41
http://subversions.gnu.org/cgi-bin/cvsweb/guile/guile-core/libguile/ChangeLog.diff?r1=1.1222&r2=1.1223
http://subversions.gnu.org/cgi-bin/cvsweb/guile/guile-core/libguile/continuations.c.diff?r1=1.29&r2=1.30

Patches:
Index: guile/guile-core/HACKING
diff -u guile/guile-core/HACKING:1.40 guile/guile-core/HACKING:1.41
--- guile/guile-core/HACKING:1.40       Sat Dec 23 09:27:04 2000
+++ guile/guile-core/HACKING    Thu Dec 28 08:06:55 2000
@@ -130,13 +130,8 @@
 
 - The Guile tree should compile without warnings under the following
 GCC switches, which are the default in the current configure script:
-    -O2 -Wall -Wpointer-arith -Wmissing-prototypes The only warnings
-which can be tolerated are those about variables being clobbered by
-longjmp/vfork in eval.c.  The variables in question are critical to
-the interpreter's performance; as far as I can tell, it is
-difficult/annoying to avoid these warnings without slowing the system
-down substantially.  (If you can figure out a good fix, I'd be happy
-to see it.)
+
+    -O2 -Wall -Wpointer-arith -Wmissing-prototypes
 
 Note that the warnings generated vary from one version of GCC to the
 next, and from one architecture to the next (apparently).  To provide
Index: guile/guile-core/libguile/ChangeLog
diff -u guile/guile-core/libguile/ChangeLog:1.1222 
guile/guile-core/libguile/ChangeLog:1.1223
--- guile/guile-core/libguile/ChangeLog:1.1222  Thu Dec 28 07:09:56 2000
+++ guile/guile-core/libguile/ChangeLog Thu Dec 28 08:06:56 2000
@@ -1,5 +1,12 @@
 2000-12-28  Dirk Herrmann  <address@hidden>
 
+       * continuations.c (scm_make_continuation):  Make variable cont
+       volatile to let the compiler know that it won't be clobbered by
+       longjmp.  (It wouldn't be anyway, but for some reason the compiler
+       is not able to see that.)
+
+2000-12-28  Dirk Herrmann  <address@hidden>
+
        This patch re-introduces the unused member "documentation" of
        struct scm_subr_entry as requested by Mikael Djurfeldt.
 
Index: guile/guile-core/libguile/continuations.c
diff -u guile/guile-core/libguile/continuations.c:1.29 
guile/guile-core/libguile/continuations.c:1.30
--- guile/guile-core/libguile/continuations.c:1.29      Wed Dec 20 14:27:09 2000
+++ guile/guile-core/libguile/continuations.c   Thu Dec 28 08:06:56 2000
@@ -111,7 +111,7 @@
 SCM 
 scm_make_continuation (int *first)
 {
-  SCM cont;
+  volatile SCM cont;
   scm_contregs *continuation;
   scm_contregs *rootcont = SCM_CONTREGS (scm_rootcont);
   long stack_size;