[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: SCM_EVALIM2
From: |
Dirk Herrmann |
Subject: |
Re: SCM_EVALIM2 |
Date: |
Thu, 31 May 2001 10:04:54 +0200 (MEST) |
On 31 May 2001, Marius Vollmer wrote:
> Dirk Herrmann <address@hidden> writes:
>
> > On Sat, 26 May 2001, Dirk Herrmann wrote:
> >
> > > when compiling guile with -W in addition to -Wall, in eval.c I get two
> > > 'value computed is not used' warnings, both related to a usage of
> > > SCM_EVALIM2. These two uses of SCM_EVALIM2, btw., are the only ones
> > > anyway and I wonder, if we shouldn't rather get rid of that macro: It's
> > > only use in the above to places seems to be for some error checking, and
> > > IMO it would be better if that was done explicitly.
> >
> > Well, I'd better said 'get rid of the calls to that macro in gc.c'. The
> > macro is used in gc.h to simplify the definition of other macros there.
>
> [I think you mean eval.h, right?]
>
> Hmm, it is used in code that is quite longish already, for a macro
> expansion, and I'd say that inlining the definiton of SCM_EVALIM2 will
> not improve that.
Ooops. What I actually meant was: Replace the two calls to SCM_EVALIM2
in eval.c by the error checks that they actually represent. Keep
SCM_EVALIM2 as an internal macro in eval.h.
Hopefully I got it right this time.
Best regards,
Dirk Herrmann