[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Forwarded patch for modular exponentiation support (GMP powm)
From: |
Kevin Ryde |
Subject: |
Re: Forwarded patch for modular exponentiation support (GMP powm) |
Date: |
Mon, 16 Feb 2004 08:08:16 +1000 |
User-agent: |
Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) |
Eric Hanchrow <address@hidden> writes:
>
> + if (!coerce_to_big (k, k_tmp))
> + {
> + position_of_wrong_type = 2;
> + goto cleanup;
I'd be inclined to put the necessary clears inline there,
if (! coerce_and_init (k, k_tmp))
{
mpz_clear (n_tmp);
SCM_WRONG_TYPE_ARG (SCM_ARG2, k);
}
if (! coerce_and_init (m, m_tmp))
{
mpz_clear (n_tmp);
mpz_clear (k_tmp);
SCM_WRONG_TYPE_ARG (SCM_ARG3, m);
}
Which seems a bit cleaner to me than setting flags.
Or maybe it's just my prejudices against the sort of idiocies with
flags that I remember advocated in Pascal texts. :-)
- Re: Forwarded patch for modular exponentiation support (GMP powm), Kevin Ryde, 2004/02/09
- Re: Forwarded patch for modular exponentiation support (GMP powm), Kevin Ryde, 2004/02/09
- Message not available
- Re: Forwarded patch for modular exponentiation support (GMP powm), Kevin Ryde, 2004/02/10
- Re: Forwarded patch for modular exponentiation support (GMP powm), Eric Hanchrow, 2004/02/11
- Re: Forwarded patch for modular exponentiation support (GMP powm), Kevin Ryde, 2004/02/11
- Re: Forwarded patch for modular exponentiation support (GMP powm), Eric Hanchrow, 2004/02/11
- Re: Forwarded patch for modular exponentiation support (GMP powm), Kevin Ryde, 2004/02/13
- Re: Forwarded patch for modular exponentiation support (GMP powm), Eric Hanchrow, 2004/02/14
- Re: Forwarded patch for modular exponentiation support (GMP powm),
Kevin Ryde <=