[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Turning `scm_is_pair ()' into a macro
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Turning `scm_is_pair ()' into a macro |
Date: |
Thu, 15 Dec 2005 10:39:59 +0100 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) |
Hi,
Marius Vollmer <address@hidden> writes:
> Yep. But what about an inline function? There is some machinery in
> inline.h for this and we already use it for scm_cell, for example.
I'm all in favor of inline functions. But since we want to support
compilers that don't support inlining, we have to use the whole
machinery that's in `inline.h'. That machinery is only used in
`inline.h', while we would like `scm_is_pair ()' to be defined in
`pairs.h'.
IOW, making the inlining machinery easily usable is not that easy, and,
well, I'm lazy too. ;-) Do you have a suggestion for this?
Since `scm_is_pair ()' was already in 1.7.2, maybe it'd make sense to
keep a non-inlined version of it. Maybe not (e.g., if we are to change
library version numbers).
BTW, below is a related fix that I forgot to post earlier.
Thanks,
Ludovic.
2005-12-15 Ludovic Courtès <address@hidden>
* socket.c: Include "libguile/pairs.h".
--- orig/libguile/socket.c
+++ mod/libguile/socket.c
@@ -35,6 +35,7 @@
#include "libguile/validate.h"
#include "libguile/socket.h"
+#include "libguile/pairs.h"
#ifdef __MINGW32__
#include "win32-socket.h"