[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patches from pkgsrc - patch-aa
From: |
Ludovic Courtès |
Subject: |
Re: patches from pkgsrc - patch-aa |
Date: |
Sat, 16 Feb 2008 12:46:06 +0100 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) |
Hi,
Greg Troxel <address@hidden> writes:
> $NetBSD: patch-aa,v 1.11 2007/07/20 00:09:22 gdt Exp $
>
> Use a pointer, instead of an array, to avoid an error on Darwin.
> Patch from DarwinPorts.
>
> --- libguile/guile.c.orig 2007-05-09 16:22:03.000000000 -0400
> +++ libguile/guile.c
> @@ -68,7 +68,7 @@ main (int argc, char **argv)
> {
> #if !defined (__MINGW32__)
> /* libtool automagically inserts this variable into your executable... */
> - extern const lt_dlsymlist lt_preloaded_symbols[];
> + extern const lt_dlsymlist *lt_preloaded_symbols;
> lt_dlpreload_default (lt_preloaded_symbols);
> #endif
> scm_boot_guile (argc, argv, inner_main, 0);
I was inclined to install this one since it's harmless. I did a bit of
research to get more information and found this:
http://permalink.gmane.org/gmane.os.netbsd.devel.pkgsrc.bulk/2337
http://lists.macosforge.org/pipermail/macports-changes/2007-March/003715.html
The patch supposedly fixes this error:
guile.c:91: error: array type has incomplete element type
However, if <ltdl.h> is included, then `lt_dlsymlist' is necessarily
typedef'd, so there's not reason such an error would occur. I would
expect an ltdl version mismatch perhaps, a broken compiler, or something
like that.
Thus, I'd say "no", unless MacPorts/Pkgsrc folks can provide some more
explanations.
(BTW, we should use `LTDL_SET_PRELOADED_SYMBOLS ()', which does exactly
the same as what we're doing.)
Thanks,
Ludovic.
- Honor `$TMPDIR' in `guile-snarf', Ludovic Courtès, 2008/02/12
- Re: Honor `$TMPDIR' in `guile-snarf', Neil Jerram, 2008/02/12
- Re: Honor `$TMPDIR' in `guile-snarf', Bruce Korb, 2008/02/12
- Re: Honor `$TMPDIR' in `guile-snarf', Ludovic Courtès, 2008/02/12
- Re: Honor `$TMPDIR' in `guile-snarf', Aleksej Saushev, 2008/02/13
- Re: Honor `$TMPDIR' in `guile-snarf', Thien-Thi Nguyen, 2008/02/14
- Re: Honor `$TMPDIR' in `guile-snarf', Aleksej Saushev, 2008/02/14
- Pkgsrc patches, Ludovic Courtès, 2008/02/14
- Re: Pkgsrc patches, Greg Troxel, 2008/02/15
- patches from pkgsrc - patch-aa, Greg Troxel, 2008/02/15
- Re: patches from pkgsrc - patch-aa,
Ludovic Courtès <=
- Re: Pkgsrc patches: patch-ae, Greg Troxel, 2008/02/15
- Re: Pkgsrc patches: patch-ae, Ludovic Courtès, 2008/02/16
- Re: Pkgsrc patches: patch-ae, Greg Troxel, 2008/02/18
- Re: Pkgsrc patches: patch-ag, Greg Troxel, 2008/02/15
- Re: Pkgsrc patches: patch-ag, Ludovic Courtès, 2008/02/16
- Re: Pkgsrc patches: patch-ag, Greg Troxel, 2008/02/18
- Re: Pkgsrc patches: patch-ag, Ludovic Courtès, 2008/02/18
- Re: Pkgsrc patches: patch-ag, Greg Troxel, 2008/02/18
- Re: Pkgsrc patches: patch-ah, Greg Troxel, 2008/02/15
- Re: Pkgsrc patches: patch-aj, Greg Troxel, 2008/02/15