[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pushed to master: extensibility to (ice-9 session)
From: |
Ludovic Courtès |
Subject: |
Re: pushed to master: extensibility to (ice-9 session) |
Date: |
Tue, 27 Jan 2009 21:30:30 +0100 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Hello,
Andy Wingo <address@hidden> writes:
> I pushed the following patch to master. Is it OK to push to 1.8 as well?
> That way I could drop some modules from guile-lib, and make guile-lib
> depend on guile >= 1.8.x.
Looks OK to me. (Too bad this module isn't documented BTW.) Do you
have example use cases?
> (Perhaps we can set up a list for patches that get pushed to Guile ?)
Yes!
A few remarks:
> +(define *value-help-handlers* '())
The convention within Guile is rather `%'-prefixed names for globals, as
in `%load-path'.
> + (let ((value (local-eval (cadr name) env)))
> + (cond ((try-value-help (cadr name) value)
> + => noop)
> + ((object-documentation value)
> + => write-line)
> + (else (not-found 'documentation (cadr name))))))
Shouldn't `object-documentation' as a default value helper, as in:
(define %value-help-handlers
`(,(lambda (n v) (object-documentation v))))
Thanks,
Ludo'.
Re: pushed to master: extensibility to (ice-9 session), Neil Jerram, 2009/01/27