Re: [PATCH] Guildhall: fix download path and keep connection alive

[Andy Wingo]

Hi!

Sorry for the terrible delay here.

On Sun 04 Sep 2011 07:33, Ian Price <address@hidden> writes:

> Nala Ginrut <address@hidden> writes:
>
>> hi guys!
>> I realized there're two problems in our shinning Guildhall. 
>>
>> 1. When "http-download" calls "relative-uri", the first arg should be a 
>> string, say "srfi", but ("srfi").
>
> I don't see a reply to this issue like there is for the other, and it
> isn't fixed in gitorious yet, so I thought I'd weigh in.
>
> The root cause of this problem are the
>   (location ("wak-syn-param-20110103.zip"))
> entries in the file 'available.scm'. Judging by the rest of
> dorodango/sigil, this means that the file may be in an arbitrary
> subdirectory i.e. ("foo" "bar" "baz.zip"), and so just doing 'car' isn't
> going to cut it.
>
> I think a better solution is to
> a) Change the 'location' format to be a string only, this entails
> changes to a few procedures that add location properties to
> packages. I'm not sure if getting rid of the subdirs is desirable (it
> might be), but changing the format is still feasible since doro/sigil
> isn't in widespread use yet.
> or
> b) fix 'relative-uri' to take a list of paths, which matches the current
> format of locations.
>
> I went for the latter, but what do you think?

I think this is the right fix, though it's tough to tell now, as the
experimental dorodango repository appears to be down.  But I've pushed
it.  Thanks!

Andy
-- 
http://wingolog.org/