[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix library search order and don't change LD_LIBRARY_PATH
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Fix library search order and don't change LD_LIBRARY_PATH |
Date: |
Tue, 27 Nov 2012 23:59:13 +0100 |
User-agent: |
Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) |
Hi!
Mark H Weaver <address@hidden> skribis:
> From 83167214083e24a8eeac6b6e04e8035497fff73a Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Tue, 27 Nov 2012 17:44:38 -0500
> Subject: [PATCH] Fix library search order and don't change LD_LIBRARY_PATH
>
> * libguile/dynl.c (system_extensions_path): New static variable.
>
> (sysdep_dynl_link): If 'lt_dlopenext' fails, manually search
> in 'system_extensions_path'.
>
> (augment_env): Remove.
>
> (sysdep_dynl_init): Don't change LD_LIBRARY_PATH, and don't use
> lt_dladdsearchdir if GUILE_SYSTEM_EXTENSIONS_PATH is set. Instead,
> initialize 'system_extensions_path' from GUILE_SYSTEM_EXTENSIONS_PATH
> (or if it's unset: <SCM_LIB_DIR>:<SCM_EXTENSIONS_DIR>), and rely on
> sysdep_dynl_link to search those directories manually.
No need for blank lines above.
> +static char *system_extensions_path; /* library search path of last resort */
Please put the comment above, and rather something like:
/* User-defined, LT_PATH_SEP-separated extension search path. */
Hopefully this time we’re really done. Thanks again for your work!
Ludo’.