[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al |
Date: |
Thu, 29 Nov 2012 00:46:55 +0100 |
User-agent: |
Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) |
Hi Mark,
Mark H Weaver <address@hidden> skribis:
> From 4a78f4a638334a5bd8eb08308891b541bbde9b1e Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Wed, 28 Nov 2012 18:01:35 -0500
> Subject: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH
> et al.
>
> * libguile/load.c (scm_parse_path_with_ellipsis): New procedure.
> (scm_init_load_path): Use 'scm_parse_path_with_ellipsis' to
> handle GUILE_LOAD_PATH and GUILE_LOAD_COMPILED_PATH.
>
> * libguile/load.h (scm_parse_path_with_ellipsis): Add prototype.
>
> * doc/ref/api-evaluation.texi (Load Paths): Add docs.
> ---
> doc/ref/api-evaluation.texi | 9 +++++++++
> libguile/load.c | 31 +++++++++++++++++++++++++++++--
> libguile/load.h | 1 +
> 3 files changed, 39 insertions(+), 2 deletions(-)
[...]
> +a list and return the resulting list with @var{base} (a list) spliced in
> +place of the @code{...} path component, if present, or else @var{base}
> +is added to the end. If @var{path} is @code{#f}, @var{base} is
> +returned.
Looks clean to me.
> +#define FUNC_NAME s_scm_parse_path_with_ellipsis
> +{
> + SCM ellipsis = scm_from_latin1_string ("...");
Use ‘SCM_SYMBOL’ instead.
Modulo that, feel free to commit.
Thanks for working on this!
Ludo’.
PS: I’ve started updating NEWS.
- Re: Adding to the end of the load path, (continued)
- Re: Adding to the end of the load path, Andreas Rottmann, 2012/11/15
- Re: Adding to the end of the load path, Ludovic Courtès, 2012/11/15
- Re: Adding to the end of the load path, Mark H Weaver, 2012/11/15
- Re: Adding to the end of the load path, Ludovic Courtès, 2012/11/15
- Re: Adding to the end of the load path, Noah Lavine, 2012/11/15
- Re: Adding to the end of the load path, Noah Lavine, 2012/11/16
- Re: Adding to the end of the load path, Bruce Korb, 2012/11/16
- Re: Adding to the end of the load path, Mark H Weaver, 2012/11/16
- Re: Adding to the end of the load path, Noah Lavine, 2012/11/16
- [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al, Mark H Weaver, 2012/11/28
- Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al,
Ludovic Courtès <=
- Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al, Mark H Weaver, 2012/11/28
- Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al, Ludovic Courtès, 2012/11/29