[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Support open-process and friends on MS-Windows
From: |
Eli Zaretskii |
Subject: |
Re: Support open-process and friends on MS-Windows |
Date: |
Sat, 25 Jun 2016 16:20:57 +0300 |
> From: address@hidden (Ludovic Courtès)
> Cc: Andy Wingo <address@hidden>, address@hidden
> Date: Sat, 25 Jun 2016 15:02:42 +0200
>
> >> Great! I have two nits. One, if it is possible for you, please attach
> >> the patch in the format that "git format-patch" makes. That makes it
> >> easy to apply, otherwise I have to futz around with --author and I could
> >> accidentally fat-finger it and get it wrong.
> >>
> >> Secondly, please make w32-proc override the definitions of
> >> HAVE_GETPRIORITY, HAVE_SETPRIORITY, HAVE_SCHED_GETAFFINITY, and
> >> HAVE_SCHED_SETAFFINITY. That way you won't need this kind of change
> >> either:
> >>
> >> > -#if HAVE_GETPRIORITY
> >> > +#if HAVE_GETPRIORITY || defined __MINGW32__
> >>
> >> If you've already discussed this with Ludovic and decided to go this way
> >> explicitly, please disregard this second nit.
> >>
> >> I will also wait a day or two for any comments from Ludovic before
> >> applying.
> >
> > Thanks, I will wait for Ludovic to tell he's okay with overriding the
> > HAVE_* macros,
>
> Yes, I agree with Andy, I think it’ll be nicer.
>
> > and will send a format-patch formatted changes after that.
>
> Cool, thank you!
Thanks, updated patch attached below.
0001-Provide-support-for-open-process-and-related-functio.patch
Description: Text Data
- Support open-process and friends on MS-Windows, Eli Zaretskii, 2016/06/24
- Re: Support open-process and friends on MS-Windows, Andy Wingo, 2016/06/24
- Re: Support open-process and friends on MS-Windows, Ludovic Courtès, 2016/06/24
- Re: Support open-process and friends on MS-Windows, Eli Zaretskii, 2016/06/24
- Re: Support open-process and friends on MS-Windows, Eli Zaretskii, 2016/06/25
- Re: Support open-process and friends on MS-Windows, Andy Wingo, 2016/06/25
- Re: Support open-process and friends on MS-Windows, Eli Zaretskii, 2016/06/25
- Re: Support open-process and friends on MS-Windows, Ludovic Courtès, 2016/06/25
- Re: Support open-process and friends on MS-Windows,
Eli Zaretskii <=
- Re: Support open-process and friends on MS-Windows, Eli Zaretskii, 2016/06/25
- Re: Support open-process and friends on MS-Windows, Andy Wingo, 2016/06/25
- Re: Support open-process and friends on MS-Windows, Eli Zaretskii, 2016/06/25