248/376: Improved error message when encountering unsupported file types

[Ludovic Courtès]

civodul pushed a commit to tag 1.8
in repository guix.

commit 2a4dbcff74c9af467b6d21828468dbba860dd979
Author: Eelco Dolstra <address@hidden>
Date:   Tue Oct 14 10:51:19 2014 +0200

    Improved error message when encountering unsupported file types
    
    Fixes #269.
---
 src/libstore/local-store.cc |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/libstore/local-store.cc b/src/libstore/local-store.cc
index f91a088..f08c877 100644
--- a/src/libstore/local-store.cc
+++ b/src/libstore/local-store.cc
@@ -551,9 +551,9 @@ static void canonicalisePathMetaData_(const Path & path, 
uid_t fromUid, InodesSe
     if (lstat(path.c_str(), &st))
         throw SysError(format("getting attributes of path ‘%1%’") % path);
 
-    /* Really make sure that the path is of a supported type.  This
-       has already been checked in dumpPath(). */
-    assert(S_ISREG(st.st_mode) || S_ISDIR(st.st_mode) || S_ISLNK(st.st_mode));
+    /* Really make sure that the path is of a supported type. */
+    if (!(S_ISREG(st.st_mode) || S_ISDIR(st.st_mode) || S_ISLNK(st.st_mode)))
+        throw Error(format("file ‘%1%’ has an unsupported type") % path);
 
     /* Fail if the file is not owned by the build user.  This prevents
        us from messing up the ownership/permissions of files