[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
01/02: download: Protect against dangling symlinks in $SSL_CERT_DIR.
From: |
Ludovic Courtès |
Subject: |
01/02: download: Protect against dangling symlinks in $SSL_CERT_DIR. |
Date: |
Fri, 16 Dec 2016 17:02:45 +0000 (UTC) |
civodul pushed a commit to branch master
in repository guix.
commit 580deec5b44d623e994e59ef07e9e0c5496762fd
Author: Ludovic Courtès <address@hidden>
Date: Fri Dec 16 18:00:01 2016 +0100
download: Protect against dangling symlinks in $SSL_CERT_DIR.
Reported by Christopher Baines <address@hidden>
in <https://bugs.gnu.org/25213>.
* guix/build/download.scm (make-credendials-with-ca-trust-files): Check
whether FILE exists before calling
'set-certificate-credentials-x509-trust-file!'.
---
guix/build/download.scm | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/guix/build/download.scm b/guix/build/download.scm
index 8e32b3d..203338b 100644
--- a/guix/build/download.scm
+++ b/guix/build/download.scm
@@ -289,9 +289,12 @@ DIRECTORY. Those authority certificates are checked when
(string-suffix? ".pem" file)))
'())))
(for-each (lambda (file)
- (set-certificate-credentials-x509-trust-file!
- cred (string-append directory "/" file)
- x509-certificate-format/pem))
+ (let ((file (string-append directory "/" file)))
+ ;; Protect against dangling symlinks.
+ (when (file-exists? file)
+ (set-certificate-credentials-x509-trust-file!
+ cred file
+ x509-certificate-format/pem))))
(or files '()))
cred))