guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

22/30: gnu: openssl: Use invoke instead of system*.


From: Mark H. Weaver
Subject: 22/30: gnu: openssl: Use invoke instead of system*.
Date: Fri, 16 Mar 2018 05:03:38 -0400 (EDT)

mhw pushed a commit to branch core-updates
in repository guix.

commit 05f6e601412a96ca5a4a318e79b11a24b7c764f7
Author: Mark H Weaver <address@hidden>
Date:   Fri Mar 16 03:56:45 2018 -0400

    gnu: openssl: Use invoke instead of system*.
    
    * gnu/packages/tls.scm (openssl, openssl-next)[arguments]: Use invoke.
    Add missing 'apply'.
---
 gnu/packages/tls.scm | 82 +++++++++++++++++++++++++---------------------------
 1 file changed, 40 insertions(+), 42 deletions(-)

diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
index a7944c2..573c610 100644
--- a/gnu/packages/tls.scm
+++ b/gnu/packages/tls.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès 
<address@hidden>
-;;; Copyright © 2014, 2015, 2016, 2017 Mark H Weaver <address@hidden>
+;;; Copyright © 2014, 2015, 2016, 2017, 2018 Mark H Weaver <address@hidden>
 ;;; Copyright © 2014 Ian Denhardt <address@hidden>
 ;;; Copyright © 2013, 2015 Andreas Enge <address@hidden>
 ;;; Copyright © 2015 David Thompson <address@hidden>
@@ -297,26 +297,25 @@ required structures.")
          'configure
          (lambda* (#:key outputs #:allow-other-keys)
            (let ((out (assoc-ref outputs "out")))
-             (zero?
-              (system* "./config"
-                       "shared"                   ;build shared libraries
-                       "--libdir=lib"
-
-                       ;; The default for this catch-all directory is
-                       ;; PREFIX/ssl.  Change that to something more
-                       ;; conventional.
-                       (string-append "--openssldir=" out
-                                      "/share/openssl-" ,version)
-
-                       (string-append "--prefix=" out)
-
-                       ;; XXX FIXME: Work around a code generation bug in GCC
-                       ;; 4.9.3 on ARM when compiled with -mfpu=neon.  See:
-                       ;; <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66917>
-                       ,@(if (and (not (%current-target-system))
-                                  (string-prefix? "armhf" (%current-system)))
-                             '("-mfpu=vfpv3")
-                             '()))))))
+             (apply invoke "./config"
+                    "shared"                   ;build shared libraries
+                    "--libdir=lib"
+
+                    ;; The default for this catch-all directory is
+                    ;; PREFIX/ssl.  Change that to something more
+                    ;; conventional.
+                    (string-append "--openssldir=" out
+                                   "/share/openssl-" ,version)
+
+                    (string-append "--prefix=" out)
+
+                    ;; XXX FIXME: Work around a code generation bug in GCC
+                    ;; 4.9.3 on ARM when compiled with -mfpu=neon.  See:
+                    ;; <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66917>
+                    ,@(if (and (not (%current-target-system))
+                               (string-prefix? "armhf" (%current-system)))
+                          '("-mfpu=vfpv3")
+                          '())))))
         (add-after
          'install 'make-libraries-writable
          (lambda* (#:key outputs #:allow-other-keys)
@@ -422,27 +421,26 @@ required structures.")
              (lambda* (#:key outputs #:allow-other-keys)
                (let* ((out (assoc-ref outputs "out"))
                       (lib (string-append out "/lib")))
-                 (zero?
-                  (system* "./config"
-                           "shared"                   ;build shared libraries
-                           "--libdir=lib"
-
-                           ;; The default for this catch-all directory is
-                           ;; PREFIX/ssl.  Change that to something more
-                           ;; conventional.
-                           (string-append "--openssldir=" out
-                                          "/share/openssl-" ,version)
-
-                           (string-append "--prefix=" out)
-                           (string-append "-Wl,-rpath," lib)
-
-                           ;; XXX FIXME: Work around a code generation bug in 
GCC
-                           ;; 4.9.3 on ARM when compiled with -mfpu=neon.  See:
-                           ;; 
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66917>
-                           ,@(if (and (not (%current-target-system))
-                                      (string-prefix? "armhf" 
(%current-system)))
-                                 '("-mfpu=vfpv3")
-                                 '()))))))
+                 (apply invoke "./config"
+                        "shared"                   ;build shared libraries
+                        "--libdir=lib"
+
+                        ;; The default for this catch-all directory is
+                        ;; PREFIX/ssl.  Change that to something more
+                        ;; conventional.
+                        (string-append "--openssldir=" out
+                                       "/share/openssl-" ,version)
+
+                        (string-append "--prefix=" out)
+                        (string-append "-Wl,-rpath," lib)
+
+                        ;; XXX FIXME: Work around a code generation bug in GCC
+                        ;; 4.9.3 on ARM when compiled with -mfpu=neon.  See:
+                        ;; <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66917>
+                        ,@(if (and (not (%current-target-system))
+                                   (string-prefix? "armhf" (%current-system)))
+                              '("-mfpu=vfpv3")
+                              '())))))
 
            ;; XXX: Duplicate this phase to make sure 'version' evaluates
            ;; in the current scope and not the inherited one.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]