guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

02/30: gnu-dist: Use invoke instead of system*.


From: Mark H. Weaver
Subject: 02/30: gnu-dist: Use invoke instead of system*.
Date: Fri, 16 Mar 2018 05:03:35 -0400 (EDT)

mhw pushed a commit to branch core-updates
in repository guix.

commit 6d084076b4ee0a1144dbed2d16ae2af91f5d2490
Author: Mark H Weaver <address@hidden>
Date:   Fri Mar 16 03:16:11 2018 -0400

    gnu-dist: Use invoke instead of system*.
    
    * guix/build/gnu-dist.scm (autoreconf, build): Use invoke and remove 
vestigial
    plumbing.
---
 guix/build/gnu-dist.scm | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/guix/build/gnu-dist.scm b/guix/build/gnu-dist.scm
index ad69c6c..bf1c63c 100644
--- a/guix/build/gnu-dist.scm
+++ b/guix/build/gnu-dist.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013, 2015 Ludovic Courtès <address@hidden>
+;;; Copyright © 2018 Mark H Weaver <address@hidden>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -41,24 +42,22 @@
                                     (begin
                                       (format #t "bootstrapping with `~a'...~%"
                                               file)
-                                      (zero?
-                                       (system* (string-append "./" file))))
+                                      (invoke (string-append "./" file)))
                                     (try-files files ...
                                                (else fallback ...)))))))
     (try-files "bootstrap" "bootstrap.sh" "autogen" "autogen.sh"
                (else
                 (format #t "bootstrapping with `autoreconf'...~%")
-                (zero? (system* "autoreconf" "-vfi"))))))
+                (invoke "autoreconf" "-vfi")))))
 
 (define* (build #:key build-before-dist? make-flags (dist-target "distcheck")
                 #:allow-other-keys
                 #:rest args)
-  (and (or (not build-before-dist?)
-           (let ((build (assq-ref %standard-phases 'build)))
-             (apply build args)))
-       (begin
-         (format #t "building target `~a'~%" dist-target)
-         (zero? (apply system* "make" dist-target make-flags)))))
+  (when build-before-dist?
+    (let ((build (assq-ref %standard-phases 'build)))
+      (apply build args)))
+  (format #t "building target `~a'~%" dist-target)
+  (apply invoke "make" dist-target make-flags))
 
 (define* (install-dist #:key outputs #:allow-other-keys)
   (let* ((out      (assoc-ref outputs "out"))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]