guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] Add tools for sysadmins: htop and dfc.


From: Cyril Roelandt
Subject: Re: [PATCH 0/2] Add tools for sysadmins: htop and dfc.
Date: Fri, 30 Aug 2013 22:37:40 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130518 Icedove/17.0.5

On 08/30/2013 10:58 PM, Nikita Karetnikov wrote:
More nitpicking…

+            (uri (string-append
+                  "mirror://sourceforge/htop/"
+                  version "/htop-" version ".tar.gz"))

Could you place ‘string-append’ and "mirror://sourceforge/htop/" on
the same line?


Yes. I never know what to do in such cases. Is there a document that contains these coding-style rules, such as the PEP8 for Python ?

+   (arguments '(#:tests? #f))

Why did you disable tests?  Could you add a comment about that?


Sure. There are no tests :)

Cyril.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]