Re: Git.

[Ludovic Courtès]

Andreas Enge <address@hidden> skribis:

> On Thu, Aug 29, 2013 at 10:16:37PM +0200, Cyril Roelandt wrote:
>> So, I've just tried to make git work. The attached patch allows me
>> to build Git on my x86 machine, but the build fails on my x86-64
>> machine. Any idea ?
>
> For me, everything works on x86_64 and with --system=i686-linux.
>
> The tests fail, but a few simple operations (stash, diff, pull) on the
> guix tree work. Shall I push the attached patch despite the test failures?

Yes, please (I’ll try to look at the test failures, though I’m happy to
share that with someone else.)

> +        (lambda* (#:key #:allow-other-keys #:rest args)
> +          (let ((configure (assoc-ref %standard-phases 'configure)))
> +          (apply configure args)
> +          (substitute* "Makefile"
> +            (("/bin/sh") (which "sh"))
> +            (("/usr/bin/perl") (which "perl"))
> +            (("/usr/bin/python") (which "python")))))

Please indent according to scoping, and check the return value of
CONFIGURE:

  (let ((configure (...)))
    (and (apply configure args)
         (substitute* ...)))

Thanks!

Ludo’.