Glib 2.38.0

[Andreas Enge]

Hello,

for the latest gtk+-3 version, I need glib >= 2.37.5. So I tried
to package 2.38.0.

I obtain the following error:

make[4]: Entering directory 
`/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests'
make  check-am
make[5]: Entering directory 
`/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests'
G_TEST_SRCDIR="/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests" 
G_TEST_BUILDDIR="/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests" 
G_DEBUG=gc-friendly MALLOC_CHECK_=2 MALLOC_PERTURB_=$((${RANDOM:-256} % 256))  
../../glib/gtester -k --quiet -o tmpsample.xml --test-arg=--gtester-selftest 
G_TEST_SRCDIR="/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests" 
G_TEST_BUILDDIR="/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests" 
G_DEBUG=gc-friendly MALLOC_CHECK_=2 MALLOC_PERTURB_=$((${RANDOM:-256} % 256))  
../../glib/gtester

(/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/.libs/gtester:20686): 
GLib-WARNING **: Failed to execute test binary: 
G_TEST_SRCDIR=/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests: Failed 
to execute child process 
"G_TEST_SRCDIR=/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests" (No 
such file or directory)

(/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/.libs/gtester:20686): 
GLib-WARNING **: Failed to execute test binary: 
G_TEST_BUILDDIR=/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests: Failed 
to execute child process 
"G_TEST_BUILDDIR=/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests" (No 
such file or directory)

(/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/.libs/gtester:20686): 
GLib-WARNING **: Failed to execute test binary: G_DEBUG=gc-friendly: Failed to 
execute child process "G_DEBUG=gc-friendly" (No such file or directory)

(/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/.libs/gtester:20686): 
GLib-WARNING **: Failed to execute test binary: MALLOC_CHECK_=2: Failed to 
execute child process "MALLOC_CHECK_=2" (No such file or directory)

(/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/.libs/gtester:20686): 
GLib-WARNING **: Failed to execute test binary: MALLOC_PERTURB_=210: Failed to 
execute child process "MALLOC_PERTURB_=210" (No such file or directory)
make[5]: *** [gtester-xmllint-check] Error 1
make[5]: Leaving directory 
`/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests'
make[4]: *** [check] Error 2
make[4]: Leaving directory 
`/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib/tests'
make[3]: *** [check-recursive] Error 1
make[3]: Leaving directory `/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib'
make[2]: *** [check] Error 2
make[2]: Leaving directory `/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0/glib'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/tmp/nix-build-glib-2.38.0.drv-1/glib-2.38.0'
make: *** [check] Error 2
phase `check' failed after 21 seconds
builder for `/nix/store/2k0i87fa22x1djpspmpkxcvl80s3412m-glib-2.38.0.drv' 
failed with exit code 1
@ build-failed /nix/store/2k0i87fa22x1djpspmpkxcvl80s3412m-glib-2.38.0.drv - 1 
builder for `/nix/store/2k0i87fa22x1djpspmpkxcvl80s3412m-glib-2.38.0.drv' 
failed with exit code 1
guix build: error: build failed: build of 
`/nix/store/2k0i87fa22x1djpspmpkxcvl80s3412m-glib-2.38.0.drv' failed

Notice the duplications in the command lines; the culprit seems to be the
lines in the recipe
                  ;; Honor $(TESTS_ENVIRONMENT).
                  (substitute* (find-files "." "^Makefile(\\.in)?$")
                    (("^GTESTER[[:blank:]]*=(.*)$" _ rest)
                     (string-append "GTESTER = $(TESTS_ENVIRONMENT) "
                                    rest))))
so that Makefile in glib/tests contains
   GTESTER = $(TESTS_ENVIRONMENT)  $(top_builddir)/glib/gtester
          ${GTESTER} -k --quiet -o tmpsample.xml --test-arg=--gtester-selftest 
${GTESTER}

I ended up dropping these lines and all tests pass; if you have a better
solution, please feel free to modify the recipe again.

Andreas