guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add libtheora package


From: David Thompson
Subject: Re: [PATCH] Add libtheora package
Date: Mon, 14 Oct 2013 14:37:18 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12

On 10/14/2013 05:23 AM, Andreas Enge wrote:
On Sun, Oct 13, 2013 at 07:20:59PM -0400, David Thompson wrote:
How does it look?

It compiles well and looks good, congratulations! One point, though:
If you do
    cd 
/nix/store/f06apny3g77kjk0wxzhmgl4b3ya77f0b-libtheora-1.1.1/lib/pkgconfig/
    grep Requires *.pc
you only see ogg, not vorbis.
So I think you can move libvorbis from propagated-inputs into regular inputs.

At a later point, you might wish to add libsdl as an input (I think you were
working on it already.)

Andreas


Thanks for the feedback. Here's an updated patch.

Attachment: 0001-Add-libtheora-package.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]