guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: luajit recipe


From: Andreas Enge
Subject: Re: luajit recipe
Date: Wed, 5 Feb 2014 00:27:30 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Hello,

On Tue, Feb 04, 2014 at 10:46:25PM +0100, Raimon Grau wrote:
> Here's the luajit recipe. I'd appreciate any comments you have on that
> (It's my first (hopefully not the last) contribution to this project).

excellent!

Just a few very quick comments:

> (define-module (gnu packages luajit)

If you add a module/file, you also need to "register" it in gnu-system.am.
Here, there is already a module lua in the file lua.scm. It would probably
make sense to add your package there.

>     (description
>      "LuaJIT is a Just-In-Time Compiler (JIT) for the Lua
> programming language. Lua is a powerful, dynamic and light-weight programming
> language. It may be embedded or used as a general-purpose, stand-alone
> language.
> 
> LuaJIT is Copyright © 2005-2014 Mike Pall")

You should write two spaces after the "." at the end of a sentence. I would
drop the second paragraph (which is also likely to change with newer
versions).

I did not check anything else. Thanks for contributing!

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]