guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4 v2] gnu: Enable tests in Python 3.


From: Ludovic Courtès
Subject: Re: [PATCH 3/4 v2] gnu: Enable tests in Python 3.
Date: Sat, 22 Mar 2014 15:32:41 +0100
User-agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux)

Cyril Roelandt <address@hidden> skribis:

> * gnu/packages/python.scm: enable tests for Python 3
> * gnu/packages/python-fix-tests.patch: New file.
> * gnu/packages/gnu-system.am (dist_patch_DATA): add it.

OK, with one detail:

> ++    @unittest.skipUnless(os.path.exists("/etc/gai.conf"),
> ++                         "getaddrinfo() will fail")
> +     def testGetaddrinfo(self):

Is this an upstream patch?  If yes, then fine, otherwise I think we
should not mention gai.conf since it’s really not the issue.

So @unittest.skipUnless(false, "getaddrinfo() will fail") would be good
enough IMO.

OK to push with these last thing addressed.  :-)

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]