Re: libpthread fails to build as an add-on

[Ludovic Courtès]

Manolis Ragkousis <address@hidden> skribis:

> In the debian package I saw there are 2 patches that add this.
>
>>  +libc_add_on_canonical=libpthread
>>  +libc_add_on_subdirs=.
>
> How does this change the configure process?

Libc’s top-level configure file expects these two variables to be set by
the add-on’s ‘configure’ script:

--8<---------------cut here---------------start------------->8---
    libc_add_on_frag=$libc_add_on_srcdir/configure
    libc_add_on_canonical=
    libc_add_on_config_subdirs=
    if test -r "$libc_add_on_frag"; then
      AC_MSG_NOTICE(running configure fragment for add-on $libc_add_on)
      libc_add_on_canonical=unknown
      libc_add_on_subdirs=
      . "$libc_add_on_frag"         ##### ← here, runs libpthread/configure
      test -z "$libc_add_on" || {
        configured_add_ons="$configured_add_ons $libc_add_on"
        if test "x$libc_add_on_canonical" = xunknown; then
          AC_MSG_ERROR(fragment must set \$libc_add_on_canonical)
        fi
--8<---------------cut here---------------end--------------->8---

So when libpthread is built as an add-on, libpthread/configure must set
them, AFAIU.

HTH,
Ludo’.