Re: [PATCH] gnu: Add abbaye

[Ludovic Courtès]

"Thompson, David" <address@hidden> skribis:

> On Thu, May 1, 2014 at 12:27 PM, Ludovic Courtès <address@hidden> wrote:
>> I noticed that ‘abbaye’ segfaults for me, immediately after opening its
>> first window (splash screen?).
>>
>
> That crash happens with the old version of the sdl-image package
> because it can't use libpng to open images.  Did something go wrong
> where the fixed sdl-image package isn't being used?

Looking at the strace output, it does seem to relate to libpng:

--8<---------------cut here---------------start------------->8---
open("/gnu/store/hf5kklv837xbfcv6gc7gpsj36l69j3sj-glibc-2.19/lib/libpng15.so.15",
 O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/gnu/store/6z7k9ms4sf367c3phl7djhb740ly3dqi-gcc-4.8.2/lib/libpng15.so.15",
 O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/gnu/store/hf5kklv837xbfcv6gc7gpsj36l69j3sj-glibc-2.19/lib/libpng15.so.15",
 O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
close(6)                                = 0
munmap(0x7f09053e2000, 4096)            = 0
--- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0x8} ---
--8<---------------cut here---------------end--------------->8---

And indeed, ‘abbaye’ is not explicitly linked against libpng, so it
can’t find it.

If I do:

--8<---------------cut here---------------start------------->8---
LD_LIBRARY_PATH=/gnu/store/naxqxdf7f6lfpy4h481h8j8hs2r44v09-libpng-1.5.17/lib 
/gnu/store/9gfzrsj71ph5pk2hxn7mmpsfflz0jpc7-abbaye-1.13/bin/abbaye
--8<---------------cut here---------------end--------------->8---

Then it works like a charm.

I suppose we need to add -lpng on the link command line?

BTW, the splash screen says “freeware”; would be great if we could
change that to “free software”.

(Seeing this game makes me feel younger.  ;-))

Thanks,
Ludo’.