guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Make gtk-glext depend on pangox-compat and remove worka


From: John Darrington
Subject: Re: [PATCH] gnu: Make gtk-glext depend on pangox-compat and remove workaround patch
Date: Wed, 28 May 2014 13:17:28 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, May 28, 2014 at 01:12:59PM +0200, John Darrington wrote:
     On Wed, May 28, 2014 at 11:57:28AM +0200, Ludovic Court??s wrote:
          Hi John,
          
          Could you make it two separate patches?  Why is the patch no longer
          needed?
     
     The patch is no longer needed because of the new dependency.  I guess I 
could
     make it two changes, but in my opinion, they belong together.

BTW.  Both of your questions are a good example of why I believe the *reason*
for a change is far more useful in a commit message, than the details
of what has changed (which is redundant anyway, since it could be seen by
running "git diff").

J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]