guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] guix lint: check whether descriptions and synopses start


From: Ludovic Courtès
Subject: Re: [PATCH 3/5] guix lint: check whether descriptions and synopses start with an upper-case letter.
Date: Sun, 28 Sep 2014 18:09:20 +0200
User-agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.3 (gnu/linux)

Cyril Roelandt <address@hidden> skribis:

> * guix/scripts/lint.scm (check-description-style, 
> check-synopsis-start-upper-case): New methods
> * tests/lint.scm: Test them.

Please specify the test names, and wrap lines.

> +(define (start-with-upper-case s)
> +  (char-set-contains? char-set:upper-case (string-ref s 0)))

Rather ‘starts-with-capital-letter?’ (with the question mark, as is
conventional, and more grammatically correct I think.)

Also it may be worth checking that S has one or more character, so
gracefully handle empty synopses.

OK to push with these changes, thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]