guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add ntp


From: Mark H Weaver
Subject: Re: [PATCH] gnu: Add ntp
Date: Sat, 18 Oct 2014 12:24:56 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.94 (gnu/linux)

John Darrington <address@hidden> writes:

> +(define-public ntp
> +  (package
> +   (name "ntp")
> +   (version "4.2.6p5")
> +   (source (origin
> +         (method url-fetch)
> +         (uri (string-append 
> "http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-";
> +                                (string-take version 3) "/ntp-" 

Instead of 'string-take', please import (srfi srfi-1) and then do this:

  (string-join (take (string-split version #\.) 2)
               ".")

We use this pattern in a number of other places -- search for
"string-join" in gnu/packages/*.scm to find them.  I suppose we should
add a procedure specifically for this, but it can wait, and it should be
in a separate commit anyway.

> +                                version ".tar.gz"))
> +         (sha256
> +          (base32
> +           "077r69a41hasl8zf5c44km7cqgfhrkaj6a4jnr75j7nkz5qq7ayn"))))
> +   (native-inputs `(("which" ,which)))
> +   (build-system gnu-build-system)
> +   (synopsis "Real time clock synchonization system")
> +   (description "NTP is a system designed to synchronize the clocks of
> +computers over a network.")
> +   (license (x11-style 
> +             "http://www.eecis.udel.edu/~mills/ntp/html/copyright.html";
> +             "A non-copyleft free licence from the University of Delaware"))
> +   (home-page "http://www.ntp.org";)))

Okay to commit with the change above.

    Thanks!
      Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]