Re: ‘strip’ phase

[Ludovic Courtès]

Mark H Weaver <address@hidden> skribis:

> address@hidden (Ludovic Courtès) writes:

[...]

>> I think the ‘strip’ phase is fine this way: sure, it ends up invoking
>> ‘strip’ on files that are not ELF files, but it’s harmless.  So we get
>> these extra warnings in the build log, but they are really harmless.
>
> Large numbers of spurious warnings are not harmless, because they make
> it unlikely that anyone will notice the warnings worth our attention.
> They condition us to ignore all warnings, because it's too much work to
> look through them all.

Right.

>> Conversely, attempts to be more selective may miss actual ELF files.
>
> True, but this is more harmless than the spurious warnings, IMO.  It
> merely means that we failed to save some disk space.
>
> IMO, the best solution is to check for the presence of ELF headers
> ourselves.  We already have ELF code in Guile master.

Yes, that sounds good.  Instead of relying on Guile’s ELF code, perhaps
it would be enough to check for the presence of the ELF magic bytes?

Ludo’.