Re: [PATCH 2/4] gnu: Add irrlicht.

[Ludovic Courtès]

David Thompson <address@hidden> skribis:

> From 2eac67986d62e8d81857a7148421ab79d327f3e1 Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Fri, 5 Sep 2014 13:16:50 -0400
> Subject: [PATCH 2/4] gnu: Add irrlicht.
>
> * gnu/packages/games.scm (irrlicht): New variable.

[...]

> +              (uri (string-append
> +                    "mirror://sourceforge/irrlicht/Irrlicht%20SDK/"
> +                    (string-join (take (string-split version #\.) 2) ".")

Please use ‘version-major+minor’.

> +    (description
> +     "The Irrlicht Engine is a high performance realtime 3D engine written in
> +C++.")

Could you expound a little bit?  :-)

> +    (license zlib)))

‘zlib’ here refers to the <package>, not to the <license>.  You probably
need to a #:prefix in the import and rename references to the licenses.

Thanks,
Ludo’.