guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/13] gnu: subversion: Propagate env variables to hooks.


From: Ludovic Courtès
Subject: Re: [PATCH 01/13] gnu: subversion: Propagate env variables to hooks.
Date: Sat, 22 Nov 2014 12:02:59 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Eric Bavier <address@hidden> skribis:

> On Fri, Nov 21, 2014 at 4:24 PM, Eric Bavier <address@hidden> wrote:
>
>>
>> Ludovic Courtès writes:
>>
>> > Eric Bavier <address@hidden> skribis:
>> >
>> >> * gnu/packages/patches/subversion-propagate-env-to-hooks.patch: New
>> patch.
>> >> * gnu-system.am (dist_patch_DATA): Add it.
>> >> * gnu/packages/version-control.scm (subversion): Use it.
>> >
>> > [...]
>> >
>> >> +++ b/gnu/packages/patches/subversion-propagate-env-to-hooks.patch
>> >> @@ -0,0 +1,14 @@
>> >> +* Hooks need to inherit environment variables such as PATH, otherwise
>> simple
>> >> +  things like `ls` might fail in a hook.
>> >
>> > That looks good, but I want to make sure we’re not changing something
>> > that was purposefully made this way.
>>
>> If the behavior is similar in 1.8.10, I'll get in contact with the
>> developers.
>>
>
> According to the subversion documentation, the desired behavior is to
> execute hooks in an empty environment for security reasons (see
> http://svnbook.red-bean.com/en/1.7/svn.reposadmin.create.html#svn.reposadmin.create.hooks
> ).

OK, so I think it’s important to stick to this behavior.

> So it looks like this is a small bug in libtool.  The wrapper scripts
> libtool generates for programs use `ls' to resolve symbolic links and is
> the only utility program invoked without an absolute file name (the only
> other utility being sed).  If such a wrapper script is executed with no
> PATH set, then we get "ls: command not found" errors.  I don't think it's
> unreasonable to expect libtool's wrappers to be able to execute in an empty
> environment.

I see.  So the patch is there “just” to allow tests to run, right?

Second, the problem should affect everyone, including FHS systems, no?
How do people work around it?

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]