Re: [PATCH] gnu: Add rtorrent and libtorrent.

[David Thompson]

"Taylan Ulrich Bayırlı/Kammer\"" <address@hidden> writes:

> ===File
> /home/tub/media/src/guix/0001-gnu-Add-rtorrent-and-libtorrent.patch===
> From 1ddb6d2e6ed7cbfc60c01fdd7d2c35559d735c28 Mon Sep 17 00:00:00 2001
> From: Taylan Ulrich B <address@hidden>
> Date: Sat, 22 Nov 2014 14:38:01 +0100
> Subject: [PATCH] gnu: Add rtorrent and libtorrent.
>
> * gnu/packages/bittorrent.scm (libtorrent, rtorrent): New variables.

Please break this into 2 commits, one for each new package.

> ---
>  gnu/packages/bittorrent.scm | 67 
> ++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 66 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
> index 8b43886..a4e2ad1 100644
> --- a/gnu/packages/bittorrent.scm
> +++ b/gnu/packages/bittorrent.scm
> @@ -30,7 +30,12 @@
>    #:use-module ((gnu packages compression)
>                  #:select (zlib))
>    #:use-module (gnu packages glib)
> -  #:use-module (gnu packages gtk))
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages check)
> +  #:use-module (gnu packages ncurses)
> +  #:use-module (gnu packages curl)
> +  #:use-module (gnu packages cyrus-sasl)
> +  #:use-module (gnu packages gnupg))
>  
>  (define-public transmission
>    (package
> @@ -88,3 +93,63 @@ DHT, µTP, PEX and Magnet Links.")
>      ;;
>      ;; A few files files carry an MIT/X11 license header.
>      (license l:gpl3+)))
> +
> +(define-public libtorrent
> +  (package
> +    (name "libtorrent")
> +    (version "0.13.4")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://libtorrent.rakshasa.no/downloads/libtorrent-";
> +                    version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0ma910br5vxrfpm4f4w4942lpmhwvqjnnf9h8vpf52fw35qhjkkh"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("pkg-config" ,pkg-config)

pkg-config should be a native input.

> +              ("openssl" ,openssl)
> +              ("zlib" ,zlib)
> +              ;; Add this when you enable tests:
> +              ;; ("cppunit" ,cppunit)

This should be a native input, too, when we enable it.

> +              ))
> +    (arguments
> +     `(#:tests? #f)) ;FIXME: enable on the next release:
> +                     ;https://github.com/rakshasa/libtorrent/issues/59
> +    (synopsis "BitTorrent library of rtorrent")
> +    (description
> +     "LibTorrent is a BitTorrent library used by and developed in parallel
> +with the BitTorrent client rtorrent.  It is written in C++ with emphasis on
> +speed and efficiency.")
> +    (home-page "http://libtorrent.rakshasa.no/";)
> +    (license l:gpl2)))
> +
> +(define-public rtorrent
> +  (package
> +    (name "rtorrent")
> +    (version "0.9.4")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://libtorrent.rakshasa.no/downloads/rtorrent-";
> +                    version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "113yrrac75vqi4g8r6bgs0ggjllj9bkg9shv08vqzdhkwqg2q2mw"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("pkg-config" ,pkg-config)

Ditto.

> +              ("libtorrent" ,libtorrent)
> +              ("ncurses" ,ncurses)
> +              ("curl" ,curl)
> +              ("cyrus-sasl" ,cyrus-sasl)
> +              ("openssl" ,openssl)
> +              ("zlib" ,zlib)
> +              ("libgcrypt" ,libgcrypt)
> +              ("cppunit" ,cppunit)))

Ditto.


> +    (synopsis "BitTorrent client with ncurses interface")
> +    (description
> +     "rTorrent is a BitTorrent client with an ncurses interface.  It supports
> +full encryption, DHT, PEX, and Magnet Links.  It can also be controlled via
> +XML-RPC over SCGI.")
> +    (home-page "http://nmap.org/";)

Should be "http://libtorrent.rakshasa.no/";

> +    (license l:gpl2)))
> -- 
> 2.1.2
>
> ============================================================
>

Overall looks good.  Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate