>From 6811c72ea7b3135de1bbe4230f5b012edbfd092b Mon Sep 17 00:00:00 2001 From: Alex Kost
Date: Sun, 2 Nov 2014 13:50:27 +0300 Subject: [PATCH 1/2] emacs: Improve minibuffer messages. * emacs/guix-base.el (guix-messages, guix-result-message): Move to 'guix-messages.el'. (guix-set-buffer, guix-history-call, guix-redisplay-buffer): Adjust for the modified 'guix-result-message'. * emacs/guix-messages.el: New file. (guix-messages): Add 'profile' argument. --- emacs/guix-base.el | 113 +++--------------------------------- emacs/guix-messages.el | 154 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 161 insertions(+), 106 deletions(-) create mode 100644 emacs/guix-messages.el diff --git a/emacs/guix-base.el b/emacs/guix-base.el index 9583d49..eb88f37 100644 --- a/emacs/guix-base.el +++ b/emacs/guix-base.el @@ -30,6 +30,8 @@ (require 'cl-lib) (require 'guix-backend) (require 'guix-utils) +(require 'guix-history) +(require 'guix-messages) ;;; Profiles @@ -565,7 +567,8 @@ If NO-DISPLAY is non-nil, do not switch to the buffer." (guix-make-history-item))) (or no-display (guix-switch-to-buffer buf)))) - (guix-result-message entries entry-type search-type search-vals)) + (guix-result-message profile entries entry-type + search-type search-vals)) (defun guix-show-entries (entries buffer-type entry-type) "Display ENTRY-TYPE ENTRIES in the current BUFFER-TYPE buffer." @@ -583,7 +586,8 @@ If NO-DISPLAY is non-nil, do not switch to the buffer." (guix-show-entries entries buffer-type entry-type) (guix-set-vars profile entries buffer-type entry-type search-type search-vals) - (guix-result-message entries entry-type search-type search-vals)) + (guix-result-message profile entries entry-type + search-type search-vals)) (defun guix-make-history-item () "Make and return a history item for the current buffer." @@ -642,113 +646,10 @@ This function will not update the information, use \"\\[revert-buffer]\" if you want the full update." (interactive) (guix-show-entries guix-entries guix-buffer-type guix-entry-type) - (guix-result-message guix-entries guix-entry-type + (guix-result-message guix-profile guix-entries guix-entry-type guix-search-type guix-search-vals)) -;;; Messages - -(defvar guix-messages - '((package - (id - (0 "Packages not found.") - (1 "") - (many "%d packages." count)) - (name - (0 "The package '%s' not found." val) - (1 "A single package with name '%s'." val) - (many "%d packages with '%s' name." count val)) - (regexp - (0 "No packages matching '%s'." val) - (1 "A single package matching '%s'." val) - (many "%d packages matching '%s'." count val)) - (all-available - (0 "No packages are available for some reason.") - (1 "A single available package (that's strange).") - (many "%d available packages." count)) - (newest-available - (0 "No packages are available for some reason.") - (1 "A single newest available package (that's strange).") - (many "%d newest available packages." count)) - (installed - (0 "No installed packages.") - (1 "A single package installed.") - (many "%d packages installed." count)) - (obsolete - (0 "No obsolete packages.") - (1 "A single obsolete package.") - (many "%d obsolete packages." count)) - (generation - (0 "No packages installed in generation %d." val) - (1 "A single package installed in generation %d." val) - (many "%d packages installed in generation %d." count val))) - (output - (id - (0 "Package outputs not found.") - (1 "") - (many "%d package outputs." count)) - (name - (0 "The package output '%s' not found." val) - (1 "A single package output with name '%s'." val) - (many "%d package outputs with '%s' name." count val)) - (regexp - (0 "No package outputs matching '%s'." val) - (1 "A single package output matching '%s'." val) - (many "%d package outputs matching '%s'." count val)) - (all-available - (0 "No package outputs are available for some reason.") - (1 "A single available package output (that's strange).") - (many "%d available package outputs." count)) - (newest-available - (0 "No package outputs are available for some reason.") - (1 "A single newest available package output (that's strange).") - (many "%d newest available package outputs." count)) - (installed - (0 "No installed package outputs.") - (1 "A single package output installed.") - (many "%d package outputs installed." count)) - (obsolete - (0 "No obsolete package outputs.") - (1 "A single obsolete package output.") - (many "%d obsolete package outputs." count)) - (generation - (0 "No package outputs installed in generation %d." val) - (1 "A single package output installed in generation %d." val) - (many "%d package outputs installed in generation %d." count val))) - (generation - (id - (0 "Generations not found.") - (1 "") - (many "%d generations." count)) - (last - (0 "No available generations.") - (1 "The last generation.") - (many "%d last generations." count)) - (all - (0 "No available generations.") - (1 "A single available generation.") - (many "%d available generations." count)) - (time - (0 "Generations not found.") - (1 "A single generation matching time period.") - (many "%d generations matching time period." count))))) - -(defun guix-result-message (entries entry-type search-type search-vals) - "Display an appropriate message after displaying ENTRIES." - (let* ((val (car search-vals)) - (count (length entries)) - (count-key (if (> count 1) 'many count)) - (msg-spec (guix-get-key-val guix-messages - entry-type search-type count-key)) - (format (car msg-spec)) - (args (cdr msg-spec))) - (mapc (lambda (subst) - (setq args (cl-substitute (car subst) (cdr subst) args))) - (list (cons count 'count) - (cons val 'val))) - (apply #'message format args))) - - ;;; Actions on packages and generations (defface guix-operation-option-key diff --git a/emacs/guix-messages.el b/emacs/guix-messages.el new file mode 100644 index 0000000..c77b5c0 --- /dev/null +++ b/emacs/guix-messages.el @@ -0,0 +1,154 @@ +;;; guix-messages.el --- Minibuffer messages + +;; Copyright © 2014 Alex Kost + +;; This file is part of GNU Guix. + +;; GNU Guix is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; GNU Guix is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see