Re: [PATCH] gnu: Add wmctrl.

[Ludovic Courtès]

Alex Kost <address@hidden> skribis:

> - I took the patch for fixing 64-bit bug from
>   
> <https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/X11/wmctrl/64-bit-data.patch>.
>   Should the header comment be changed?

I think this one is OK.

> - I tested it only on 32-bit machine so I don't really know how it works
>   on 64-bit.

It works for me (except that ratpoison seems not to be NetWM-compliant.)

> - Is it ok to make "wmctrl.scm" or would it be more appropriate to put
>   it into "xdisorg.scm"?

xdisorg.scm would seem preferable to me.

> +  gnu/packages/patches/wmctrl-64-fix.patch

Missing backslash.
> +    (synopsis "Command-line tool to control X Window Manager")

“to control X11 window managers”

> +    (description
> +     "Wmctrl allows to interact with an X Window Manager that is compatible
> +with the EWMH/NetWM specification.  It can query the Window Manager for

“window manager” (lower case.)

OK to push with these adjustments.

Thanks,
Ludo’.