guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] guix: scripts: Fix GUIX_BUILD_OPTIONS handling.


From: Ludovic Courtès
Subject: Re: [PATCH] guix: scripts: Fix GUIX_BUILD_OPTIONS handling.
Date: Sat, 06 Dec 2014 16:04:43 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Deck Pickard <address@hidden> skribis:

> From 9c27d995e1a622de8457209d40031b392538e0f8 Mon Sep 17 00:00:00 2001
> From: nebuli <address@hidden>
> Date: Fri, 5 Dec 2014 01:28:12 +0100
> Subject: [PATCH] guix: scripts: Fix GUIX_BUILD_OPTIONS handling.
>
> Appending to "raw" args broke optional parameters in 'guix package -I'
> and 'guix package -A', and possibly other places.  Therefore, switch to
> parsing each set of options on its own and append resulting alists
> together afterwards.
>
> * guix/scripts/archive.scm (parse-options-from): Rename from
>   (parse-options) and add explicit argument.  New form of (parse-options)
>   using its old algorithm via -from function.
> * guix/scripts/build.scm: Ditto.
> * guix/scripts/environment.scm: Ditto.
> * guix/scripts/package.scm: Ditto.
> * guix/scripts/system.scm: Ditto.

Good catch.  I’ve applied it along with a test case that reproduces the
problem and a clarification in the doc.

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]