guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing te


From: Ludovic Courtès
Subject: Re: 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test.
Date: Sun, 14 Dec 2014 23:54:18 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Federico Beffa <address@hidden> skribis:

> +        (alist-cons-before
> +         'check 'fix-failing-tests
> +         (lambda _
> +           (substitute* (find-files "numpy/linalg/tests" 
> +                                    "test_regression\\.py")
> +             (("x = np.eye(1000, 66)")
> +              "x = np.eye(10, 66)")))

Could you add a comment here explaining that this is reducing the input
matrix size (?) and why it matters?  Otherwise it may seem a bit too
magical.  :-)

Also, this kind of change would be a good candidate for ‘snippet’,
because it’s a “static” change.

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]