Re: [PATCH v4] gnu: Add bullet.

[Tomas Cech]

At Sat, 13 Dec 2014 10:58:44 -0500,
David Thompson wrote:
> 
> Tomáš Čech <address@hidden> writes:
> > ...
> > @@ -0,0 +1,13 @@
> > +diff -up bullet-2.82-r2704/CMakeLists.txt.orig 
> > bullet-2.82-r2704/CMakeLists.txt
> > +--- bullet-2.82-r2704/CMakeLists.txt.orig  2014-12-13 00:09:49.648710180 
> > +0100
> > ++++ bullet-2.82-r2704/CMakeLists.txt       2014-12-13 00:10:44.205708986 
> > +0100
> > +@@ -17,6 +17,9 @@ IF (NOT CMAKE_BUILD_TYPE)
> > +  SET(CMAKE_BUILD_TYPE "Release")
> > + ENDIF (NOT CMAKE_BUILD_TYPE) 
> > + 
> > ++SET(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS} -fPIC")
> > ++SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
> > ++
> 
> Is the second 'SET' redundant?

Yes, it is wrong.

> Rather than using this patch file, you should instead add a new build
> phase to the bullet package.  Add something like this to the arguments
> field, after '#:tests? #f':
> 
>   #:phases (alist-cons-before
>             'configure 'set-env-vars
>             (lambda _
>               (setenv "CMAKE_CXX_FLAGS"
>                       (string-append (getenv "CMAKE_C_FLAGS")
>             "-fPIC"))))

I liked that idea and used that approach. Updated patch is following...

Thanks for your review and patience.

Best regards,

S_W