Re: [PATCH] gnu: Add ninja.

[Ludovic Courtès]

宋文武 <address@hidden> skribis:

> * gnu/packages/ninja.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +          'check
> +          (lambda _
> +            (and (zero? (system "./configure.py"))
> +                 (zero? (system "./ninja ninja_test"))
> +                 ;; SubprocessTest.InterruptChild fail when using 'system*'.
> +                 ;; SubprocessTest.SetWithLots was skipped.
> +                 ;; XXX: Raise [ulimit -n] well above 1025 to make this test 
> go.

Does it mean that the test is currently failing?

> +                 (zero? (system (string-append
> +                                 "./ninja_test "
> +                                 "--gtest_filter="
> +                                 "-SubprocessTest.SetWithLots")))))

Please use ‘system*’ (with separate arguments) rather than ‘system’.
The latter runs “/bin/sh -c ...” whereas the former runs the program
directly.

Thanks,
Ludo’.