Re: [PATCH] gnu: Add smartmontools.

[Mark H Weaver]

address@hidden (Taylan Ulrich "Bayırlı/Kammer") writes:

> From db4d182a8da67102ef83e1e8f882a83bcaa69d58 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Sun, 8 Feb 2015 11:26:46 +0100
> Subject: [PATCH 2/2] gnu: Add smartmontools.
>
> * gnu/packages/admin.scm (smartmontools): New variable.
> ---
>  gnu/packages/admin.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index dacae60..40e9b80 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -1026,3 +1026,27 @@ any capabilities and whether or not it has an open 
> ended bounding set.  The
>  included utilities are designed to let admins and developers spot apps from
>  various ways that may be running with too much privilege.")
>      (license gpl2+)))
> +
> +(define-public smartmontools
> +  (package
> +    (name "smartmontools")
> +    (version "6.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://sourceforge/smartmontools/smartmontools/"
> +                    version "/smartmontools-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "06gy71jh2d3gcfmlbbrsqw7215knkfq59q3j6qdxfrar39fhcxx7"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("libcap-ng" ,libcap-ng)))
> +    (home-page "http://www.smartmontools.org/";)
> +    (synopsis "SMART harddisk control and monitoring tools")
> +    (description
> +     "The smartmontools package contains utility programs to control and
> +monitor storage systems using the Self-Monitoring, Analysis and Reporting
> +Technology System (SMART) built into most modern ATA and SCSI harddisks.  In
> +many cases, these utilities will provide advanced warning of disk degradation
> +and failure.")
> +    (license gpl2+)))

Debian claims that the license is gpl2, not gpl2+.

Please be more careful checking licenses.  Debian tends to be very
thorough about this, so a good method is to find the package on Debian,
e.g. <http://packages.debian.org/smartmontools>, select the appropriate
package (preferably the same version or close to it) and then choose the
"Copyright File" link in the right column.

Otherwise looks good to me.  Okay to push this (and libcap-ng) with
these problems fixed.

     Thanks!
       Mark