Re: [PATCH] gnu: Add ltrace.

[David Thompson]

"Taylan Ulrich Bayırlı/Kammer" <address@hidden> writes:

> From 2f8c97c384afc5b3ae1b17382024f7c3458a576f Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Mon, 9 Feb 2015 23:35:03 +0100
> Subject: [PATCH] gnu: Add ltrace.
>
> * gnu/packages/linux.scm (ltrace): New variable.
> ---
>  gnu/packages/linux.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 09e2a4c..bb06208 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -4,6 +4,7 @@
>  ;;; Copyright © 2012 Nikita Karetnikov <address@hidden>
>  ;;; Copyright © 2014, 2015 Mark H Weaver <address@hidden>
>  ;;; Copyright © 2015 Federico Beffa <address@hidden>
> +;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -670,6 +671,29 @@ images more compressible.")
>  trace of all the system calls made by a another process/program.")
>      (license bsd-3)))
>  
> +(define-public ltrace
> +  (package
> +    (name "ltrace")
> +    (version "0.7.3")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append "http://www.ltrace.org/ltrace_"; version
> +                                 ".orig.tar.bz2"))
> +             (sha256
> +              (base32
> +               "00wmbdghqbz6x95m1mcdd3wd46l6hgcr4wggdp049dbifh3qqvqf"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("libelf" ,libelf)))
> +    (arguments
> +     '(#:configure-flags '("--disable-werror")))

Could you add a comment explaining why this flag is necessary?

> +    (home-page "http://www.ltrace.org/";)
> +    (synopsis "Library call tracer for Linux")
> +    (description
> +     "ltrace intercepts and records dynamic library calls which are called by
> +an executed process and the signals received by that process.  It can also
> +intercept and print the system calls executed by the program.")
> +    (license gpl2+)))
> +
>  (define-public alsa-lib
>    (package
>      (name "alsa-lib")
> -- 
> 2.2.1
>
>

Looks good otherwise!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate