Re: [PATCH] gnu: Add ECL.

[Taylan Ulrich Bayırlı/Kammer]

Mark H Weaver <address@hidden> writes:

> In general, it's probably better to avoid unnecessary rearrangements
> like this, since it will tend to cause conflicts when other people have
> pending patches in the same module.

OK, I undid that.

> Our convention is to write (version-major+minor version) since it
> results in more readable code, even though it is a few more characters
> and will force the remaining arguments to the next line.

Done.

> Hmm.  This is very far from our conventional style for phases.  I don't
> doubt that our conventional style could be improved, but I'm fond of the
> style above either.  Although there is no mutation, it is essentially
> written in an imperative style.
>
> How about something like this instead?
>
>      '(#:phases
>        ;; The test-suite seems to assume that ECL is installed.  So re-order
>        ;; the phases, then reference the installed executable.
>        (let* ((check-phase (assq-ref %standard-phases 'check))
>               (rearranged-phases (alist-cons-after
>                                   'install 'check check-phase
>                                   (alist-delete 'check %standard-phases))))
>          (alist-cons-before
>           'check 'pre-check
>           (lambda* (#:key outputs #:allow-other-keys)
>             (substitute* '("build/tests/Makefile")
>               (("ECL=ecl")
>                (string-append
>                 "ECL=" (assoc-ref outputs "out") "/bin/ecl"))))
>           rearranged-phases))

That looks better indeed.  Done.

> Instead of this, please add the following build arguments:
>
>        #:parallel-build? #f
>        #:parallel-tests? #f

Done.

> Yowza!  I appreciate you being so thorough, but this may be a bit over
> the top :)  I'd like to hear what Ludovic thinks before okaying a push.

Thought so. :)  At least I'm halfway a license guru now.


It would be neat to have a page sequentially listing all the licenses we
support, with some short notice on each highlighting its distinguishing
features.  I had to visit all the separate FSF wiki pages linked from
guix/licenses.scm and make out my own mental map of them so to say.

It would also be neat to have a better version of
<http://www.what-license.com/>, tuned for our purposes.  (This one
doesn't support many licenses and seems to use a very bad algorithm.)

(I might find time to work on these myself.)


Taylan