guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] import: cpan: Use corelist to filter dependencies.


From: Ludovic Courtès
Subject: Re: [PATCH 3/4] import: cpan: Use corelist to filter dependencies.
Date: Sat, 14 Feb 2015 00:15:22 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Eric Bavier <address@hidden> skribis:

> * guix/import/cpan.scm (%corelist): New variable.
>   (module->dist-name, core-module?): New procedures.
>   (cpan-module->sexp)[convert-inputs]: Use them.  Include "test" dependencies
>   in converted inputs.
> * doc/guix.texi (Invoking guix import)[cpan]: Mention corelist filtering.

[...]

> +(define %corelist
> +  (let* ((perl (with-store store
> +                 (derivation->output-path
> +                  (package-derivation store perl))))
> +         (core (string-append perl "/bin/corelist")))
> +    (and (access? core X_OK)
> +         core)))

What about adding:

  (warning (_ "the 'corelist' command is unavailable, not filtering modules~%"))

?

Or perhaps it would be even better to take it from $PATH, otherwise the
situation could be confusing: even if Perl is installed, the user could
get an “unavailable” warning just because it’s not the exact same Perl.

WDYT?

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]