guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 01/01: download: Handle HTTP redirects to relative URI references.


From: Mark H Weaver
Subject: Re: 01/01: download: Handle HTTP redirects to relative URI references.
Date: Tue, 24 Feb 2015 00:44:38 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> "Mark H. Weaver" <address@hidden> skribis:
>
>> +;; XXX: Work around <http://bugs.gnu.org/19840>, present in Guile
>> +;; up to 2.0.11.
>> +(unless (or (> (string->number (major-version)) 2)
>> +            (> (string->number (minor-version)) 0)
>> +            (> (string->number (micro-version)) 11))
>
> Just a minor nit: could you change that to use ‘guile-version>?’
> instead?  It is more concise and easier to search for.

I thought about that, but it would involve importing (guix utils) from
(guix build download), and then arranging to add (guix utils) to the
list of imported modules in the derivation produced by 'url-fetch' in
(guix download), and maybe some other places.

Anyway, if we do this, we should also change the definition of
'post-2.0.7?' in the same file.

       Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]