[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bump mu/mu4e to version 0.9.11
From: |
Mark H Weaver |
Subject: |
Re: [PATCH] bump mu/mu4e to version 0.9.11 |
Date: |
Thu, 26 Feb 2015 19:00:56 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Paul van der Walt <address@hidden> writes:
> Here's my first modest patch. I use mu4e, and therefore it bothered me
> that the version in Guix was about a year old. The upgraded version
> seems to work fine for me, so that's nice.
Looks good to me, modulo a few minor nits. Please see below.
> * gnu/packages/mail.scm: Bump mu version from 0.9.9.5 -> 0.9.11
By our usual conventions, the commit log should look like this:
--8<---------------cut here---------------start------------->8---
gnu: mu: Update to 0.9.11.
* gnu/packages/mail.scm (mu): Update to 0.9.11.
--8<---------------cut here---------------end--------------->8---
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index dc33c8c..b450e91 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
Please add your copyright line to the top of the file.
> @@ -304,18 +304,21 @@ repository and Maildir/IMAP as LOCAL repository.")
> (define-public mu
> (package
> (name "mu")
> - (version "0.9.9.5")
> + (version "0.9.11")
> (source (origin
> (method url-fetch)
> - (uri (string-append "https://mu0.googlecode.com/files/mu-"
> + (uri (string-append "https://github.com/djcb/mu/archive/v"
> version ".tar.gz"))
Please add (file-name (string-append "mu-" version ".tar.gz")) as
another field to the 'origin' form, so that the file name in /gnu/store
will include "mu-" in the name. This is rarely needed, but is needed
here because the name of the file in the URI (after the last '/')
doesn't include the package name.
Otherwise it looks good to me. Can you send an updated patch?
Thanks!
Mark